You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The CSS rule of: table:not(.dcf-table):not(.ui-datepicker-calendar) td
is equivalent to: table.not-a-dcf-table.not-a-datepicker td
which has more specificity weight than even a very specific rule like: table.input-table tr td
I think these rule changes should be backed out due to:
The changes associated are to a DEPRECATED style sheet.
The specified rules are changing borders and padding and not resetting default table styles
The additions prevent a targeting of new dcf/ui components. Those new components should rely on specificity and rule targeting with normal CSS cascading rules as that was the precedent defined by not setting default styles for tables within dcf.
The text was updated successfully, but these errors were encountered:
Having spent some time reviewing this, this is an interesting one. I think the addition of :not(.ui-datepicker-calendar) does fix a problem with unintended styling of the jQuery UI datepicker; as intended. But Nic's overall concern about CSS rule specificity when using :not is valid. The CSS applied in these rules are very similar to utilizing !important. Any use of :not can prevent any additional styling from being applied. In this case, being a deprecated CSS file, it's probably ok as its intention is to retain the old styling. If a person is having issues with CSS specificity on their website, they should simply put in the work to remove the need for the deprecated CSS file altogether.
Changes to Deprecated Table Styles create an increased specificity in css rule. Further explained here.
The CSS rule of:
table:not(.dcf-table):not(.ui-datepicker-calendar) td
is equivalent to:
table.not-a-dcf-table.not-a-datepicker td
which has more specificity weight than even a very specific rule like:
table.input-table tr td
I think these rule changes should be backed out due to:
The text was updated successfully, but these errors were encountered: