Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postcss should be listed as a dep not a peer dep? #13

Closed
niftylettuce opened this issue Jan 1, 2018 · 4 comments
Closed

postcss should be listed as a dep not a peer dep? #13

niftylettuce opened this issue Jan 1, 2018 · 4 comments

Comments

@niftylettuce
Copy link

a lot of users just use something like gulp-postcss and in turn this causes this error when installing this package:

warning " > postcss-import-url@3.0.1" has unmet peer dependency "postcss@^6.0.13".

I suggest to either put a version range for postcss in peer deps or strictly put a version of postcss as a dep

@unlight
Copy link
Owner

unlight commented Jan 1, 2018

Postcss defined as peer dependency
I'll set postcss as peerdep to >=6 <7

@niftylettuce
Copy link
Author

Can you please accept my pull request? This should be listed as a dependency. From my research so far I think that almost all postcss plugins list is as a dependency.

@niftylettuce niftylettuce mentioned this issue Jan 1, 2018
@unlight unlight closed this as completed in 9d47f48 Jan 2, 2018
@unlight
Copy link
Owner

unlight commented Jan 2, 2018

so far I think that almost all postcss plugins list is as a dependency.

Well, they do it wrong. Plugins must define host dependency as peer dependency.
Proof link

I've just published v3.0.3, if problem with warning still occurs, please provide your package.json content.

@niftylettuce
Copy link
Author

I understand, however the community as a whole really doesn't seem to adhere to peerDependencies and the thought process there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants