Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inlay hints how up for candidates when it shouldn't #32

Open
TheAmg opened this issue Sep 4, 2024 · 0 comments
Open

Inlay hints how up for candidates when it shouldn't #32

TheAmg opened this issue Sep 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@TheAmg
Copy link
Contributor

TheAmg commented Sep 4, 2024

Describe the bug

When running an application with unlogged sdk 0.7.6 and mode = logAnnotatedOnly it is expected that methods that are annotated with @UnloggedMethod or classes annotated with @UnloggedClass will only be logged and yield candidates.

Consider the following class - >

class A {

    @UnloggedMethod(counter = "1")
    public String methodA()
    {
       return methodB();
    }

    public String methodB()
    {
       return valueFromDownstream;
    }
}

Class doesn't have an @UnloggedClass annotation.

Post calling methodA, an inlayHint will be rendered for methodB as well, but on clicking methodB's inlay hint, there is no candidate for it.

This can be recreated here -
Project : unlogged-spring-mvc-maven-demo
Classname : BookRestService
Method: getAll()

Demo:
https://drive.google.com/file/d/1G8weMHaWr5v5-uxO7Dle3Jmg92WphEc5/view?usp=sharing

Reproduction steps

  1. Invoke method mentioned above

Expected behavior

For no Inlay hints to be shown for a method with no candidates.

Additional context

No response

@TheAmg TheAmg added the bug Something isn't working label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant