Add timeout to client

[lafrech]

When server is down, a ConnectionRefusedError ultimately bubbles up.

It would be nice if the convert and compare methods had a timeout argument to handle this gracefully and return a dedicated exception.

[regebro]

I think this should be solved in the next release.

[lafrech]

I think this should be solved in the next release.

Did you mean in 3.x?

Because I don't see anything regarding client timeout.

I saw the --conversion-timeout added to the server, but I don't think there's been any change to the client regarding this.

I just tested and got two different errors:

• xmlrpc.client.Fault: <Fault 1: "<class 'TimeoutError'>:">
• ConnectionRefusedError: [Errno 111]

[regebro]

No, the bubbling up of a connectionerror is now handled better. That shouldn't be timed out, it's a genuine unrecoverable error. If the server is down, it's down. You'll get a connection error. The problem before is that you could get it when the server was not down.