-
-
Notifications
You must be signed in to change notification settings - Fork 865
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: default cjs package exports (#4401)
- Loading branch information
Showing
1 changed file
with
115 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,124 @@ | ||
import { readFileSync, writeFileSync } from 'node:fs' | ||
import { resolve } from 'node:path' | ||
import { readFile, writeFile } from 'node:fs/promises' | ||
// import { readFileSync, writeFileSync } from 'node:fs' | ||
import { findExports, findStaticImports, parseStaticImport } from 'mlly' | ||
import { verifyDist } from './dist-verify' | ||
|
||
function patchUnoCSSPostcssCjsExport(dtsModuleName: string) { | ||
for (const path of [`${dtsModuleName}.d.ts`, `${dtsModuleName}.d.cts`]) { | ||
const content = readFileSync(path, 'utf-8') | ||
writeFileSync( | ||
const regexp = /export\s*\{([^}]*)\}/ | ||
const defaultExportRegexp = /\s*as\s+default\s*/ | ||
const typeExportRegexp = /\s*type\s+/ | ||
|
||
// Temporal fix for unbuild cjs plugin: will work only here. | ||
// The current unbuild cjs plugin fixing only some default exports in d.cts files. | ||
// This script will not fix export { default } from '<some-specifier>'. | ||
async function fixDefaultCJSExports(path: string) { | ||
const code = await readFile(path, 'utf-8') | ||
console.log(code) | ||
|
||
const defaultExport = findExports(code).find(e => | ||
e.names.includes('default'), | ||
) | ||
|
||
if (!defaultExport) { | ||
return | ||
} | ||
|
||
const match = defaultExport.code.match(regexp) | ||
if (!match?.length) { | ||
return | ||
} | ||
|
||
let defaultAlias: string | undefined | ||
const exportsEntries: string[] = [] | ||
for (const exp of match[1].split(',').map(e => e.trim())) { | ||
const m = exp.match(defaultExportRegexp) | ||
if (m) { | ||
defaultAlias = exp.replace(m[0], '') | ||
} | ||
else { | ||
exportsEntries.push(exp) | ||
} | ||
} | ||
|
||
if (!defaultAlias) { | ||
// handle default export like: | ||
// import defaultExport from '<some-identifier>' | ||
// export default defaultExport | ||
// dts plugin will generate code like: | ||
// import defaultExport from '<some-identifier>'; | ||
// export { default } from '<some-identifier>'; | ||
const defaultStaticImport = findStaticImports(code).find(i => i.specifier === defaultExport.specifier) | ||
const defaultImport = defaultStaticImport ? parseStaticImport(defaultStaticImport).defaultImport : undefined | ||
if (!defaultExport) { | ||
return | ||
} | ||
// this will generate the following code: | ||
// import defaultExport from '<some-identifier>'; | ||
// export = defaultExport; | ||
await writeFile( | ||
path, | ||
content.replace('export { default } from \'@unocss/postcss\';', '\nexport = postcss;'), | ||
{ encoding: 'utf-8' }, | ||
code.replace( | ||
defaultExport.code, | ||
`export = ${defaultImport}`, | ||
), | ||
'utf-8', | ||
) | ||
return | ||
} | ||
|
||
let exportStatement = exportsEntries.length > 0 ? undefined : '' | ||
|
||
// replace export { type A, type B, type ... } with export type { A, B, ... } | ||
// that's, if all remaining exports are type exports, replace export {} with export type {} | ||
if (exportStatement === undefined) { | ||
const imports = findStaticImports(code).map(i => i.imports) | ||
let someExternalExport = false | ||
const allRemainingExports = exportsEntries.map((exp) => { | ||
if (someExternalExport) { | ||
return [exp, ''] as const | ||
} | ||
if (!imports.includes(exp)) { | ||
const m = exp.match(typeExportRegexp) | ||
if (m) { | ||
const name = exp.replace(m[0], '').trim() | ||
if (!imports.includes(name)) { | ||
return [exp, name] as const | ||
} | ||
} | ||
} | ||
someExternalExport = true | ||
return [exp, ''] as const | ||
}) | ||
exportStatement = someExternalExport | ||
? `;\nexport { ${allRemainingExports.map(([e, _]) => e).join(', ')} }` | ||
: `;\nexport type { ${allRemainingExports.map(([_, t]) => t).join(', ')} }` | ||
} | ||
|
||
await writeFile( | ||
path, | ||
code.replace( | ||
defaultExport.code, | ||
`export = ${defaultAlias}${exportStatement}`, | ||
), | ||
'utf-8', | ||
) | ||
} | ||
|
||
function mapDualPaths(pkgName: string, pkg: string, modules: string[]) { | ||
const prefix = `./${pkgName}/${pkg}/dist/` | ||
return modules.map(name => [ | ||
fixDefaultCJSExports(`${prefix}${name}.d.ts`), | ||
fixDefaultCJSExports(`${prefix}${name}.d.cts`), | ||
]) | ||
} | ||
|
||
// unocss | ||
patchUnoCSSPostcssCjsExport(resolve('./packages-presets/unocss/dist/postcss')) | ||
const paths = [ | ||
mapDualPaths('packages-integrations', 'eslint-config', ['index', 'flat']), | ||
mapDualPaths('packages-integrations', 'eslint-plugin', ['index']), | ||
mapDualPaths('packages-integrations', 'postcss', ['index']), | ||
mapDualPaths('packages-integrations', 'webpack', ['index']), | ||
mapDualPaths('packages-presets', 'preset-legacy-compat', ['index']), | ||
mapDualPaths('packages-presets', 'unocss', ['postcss', 'webpack']), | ||
] | ||
await Promise.all(paths.flat(2)) | ||
|
||
await verifyDist() |