Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Playground][wasm]Button, ProgressBar, Card- Text is not visible in Dark Theme #481

Open
sakshi173 opened this issue Jul 27, 2023 · 13 comments
Assignees
Labels
kind/bug Something isn't working

Comments

@sakshi173
Copy link

Current behavior

Button failed1
Progress failed
Card failed1

Expected behavior

Button correct 2
progress correct
Card correct1

How to reproduce it (as minimally and precisely as possible)

  1. Visit https://playgroundcanary.z19.web.core.windows.net/#passwordbox.
  2. Go to the Snippets Listview.
  3. Click on 'Button' or 'Card' or 'ProgressBar' snippets option.
  4. Click checkbox for dark theme.
  5. Observe that the displayed text for the selected sample is not visible in dark theme.

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

WebAssembly

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

@sakshi173 sakshi173 added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Jul 27, 2023
@jeromelaban
Copy link
Member

This issue is caused by samples not specifying theme resources for brushes.

@carlh98 carlh98 self-assigned this Aug 2, 2023
@carlh98
Copy link

carlh98 commented Aug 3, 2023

For PasswordBox and ProgressBar, the xaml that is used has Foreground harcoded for the styles, removing the values, fixes the issues since it falls back to the style of the control.
image

@agneszitte I do not know where playground gets the xaml for the example, can you point me in the right direction?

@agneszitte
Copy link
Contributor

@carlh98 prepare the snippets and share the saved links in the issue please, we will do the update when @jeromelaban and @carldebilly will be back next week

@carlh98
Copy link

carlh98 commented Aug 10, 2023

Snippets
PasswordBox
ProgressBar

I was not able to test locally, after updating to the latest VS Preview (17.8.0 Preview 1.0) I'm getting the following error, I tried updating the bootstrap packages but I'm getting the same error

2>C:\Users\ch.mathieu\.nuget\packages\uno.wasm.bootstrap\8.0.0-dev.235\build\Uno.Wasm.Bootstrap.targets(204,3): error : System.Exception: Failed to execute the linker
2>C:\Users\ch.mathieu\.nuget\packages\uno.wasm.bootstrap\8.0.0-dev.235\build\Uno.Wasm.Bootstrap.targets(204,3): error :    at Uno.Wasm.Bootstrap.ShellTask_vc93fd98a085e94454c124782127efd35ac168bc9.RunPackager() in /_/src/Uno.Wasm.Bootstrap/ShellTask.cs:line 1023
2>C:\Users\ch.mathieu\.nuget\packages\uno.wasm.bootstrap\8.0.0-dev.235\build\Uno.Wasm.Bootstrap.targets(204,3): error :    at Uno.Wasm.Bootstrap.ShellTask_vc93fd98a085e94454c124782127efd35ac168bc9.Execute() in /_/src/Uno.Wasm.Bootstrap/ShellTask.cs:line 266
2>Done building project "Uno.Playground.WASM.csproj" -- FAILED.

@MartinZikmund
Copy link
Member

@ebariche it seems this same problem is now happening in multiple places, any chance you could look into what could be causing it?

@jeromelaban
Copy link
Member

@carlh98 can you attach a binlog?

@agneszitte
Copy link
Contributor

agneszitte commented Aug 15, 2023

@carldebilly can you help to update the playground snippets with the API please?

@silviuo
Copy link

silviuo commented Aug 16, 2023

Following up on @agneszitte's post in unoventive, here are some issues I discovered when comparing snippets under the three Uno Playground variants (Canary, Staging, Prod):

CalendarView - On Prod only, the down arrow icon shows as the up arrow:

current:
image

expected:
image

InfoBar (muxc) - on Canary and Staging (Prod correct), the "Informational" Severity icon does not display the foreground "i". For all other types of severity ("Success", "Warning", "Error"), the icon displays correctly on all three builds.

current:
image

expected:
image

@jeromelaban
Copy link
Member

@silviuo interesting! Could you open individual issues for what you've found?

@silviuo
Copy link

silviuo commented Aug 16, 2023

@jeromelaban I created separate issues for the problems I mentioned in the previous comment.

Related to this particular issue, however, besides the already mentioned snippets (Button, Cards, PasswordBox, ProgressBar), I also found the following that don't display some of the text in dark mode:

  • CheckBox, Image, Path, RadioButton, Shape, ToggleButton - because of labels using hardcoded TextBlock Foreground values
    e.g.
    image

  • Panels, TextBlock - because of TextBlocks styled with "SampleSectionTextBlockStyle" StaticResource
    e.g.
    image

  • TextBox - because of TextBoxes styled with "AndroidTextBoxStyle" StaticResource
    e.g.
    image

@agneszitte
Copy link
Contributor

@silviuo can you share the links of the other issues you opened please

@silviuo
Copy link

silviuo commented Aug 16, 2023

@silviuo can you share the links of the other issues you opened please

@agneszitte

unoplatform/uno#13282

unoplatform/uno#13283

@agneszitte
Copy link
Contributor

agneszitte commented Sep 11, 2023

Snippets PasswordBox ProgressBar

I was not able to test locally, after updating to the latest VS Preview (17.8.0 Preview 1.0) I'm getting the following error, I tried updating the bootstrap packages but I'm getting the same error

2>C:\Users\ch.mathieu\.nuget\packages\uno.wasm.bootstrap\8.0.0-dev.235\build\Uno.Wasm.Bootstrap.targets(204,3): error : System.Exception: Failed to execute the linker
2>C:\Users\ch.mathieu\.nuget\packages\uno.wasm.bootstrap\8.0.0-dev.235\build\Uno.Wasm.Bootstrap.targets(204,3): error :    at Uno.Wasm.Bootstrap.ShellTask_vc93fd98a085e94454c124782127efd35ac168bc9.RunPackager() in /_/src/Uno.Wasm.Bootstrap/ShellTask.cs:line 1023
2>C:\Users\ch.mathieu\.nuget\packages\uno.wasm.bootstrap\8.0.0-dev.235\build\Uno.Wasm.Bootstrap.targets(204,3): error :    at Uno.Wasm.Bootstrap.ShellTask_vc93fd98a085e94454c124782127efd35ac168bc9.Execute() in /_/src/Uno.Wasm.Bootstrap/ShellTask.cs:line 266
2>Done building project "Uno.Playground.WASM.csproj" -- FAILED.

Snippets will be updated with the 5.0 release

@MartinZikmund MartinZikmund removed the triage/untriaged Indicates an issue requires triaging or verification. label Sep 20, 2023
@MartinZikmund MartinZikmund transferred this issue from unoplatform/uno Sep 20, 2023
@carlh98 carlh98 removed their assignment Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants