Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gallery][WASM] [Textbox] Unintended Text Selection #1459

Closed
5 tasks
jhanvi03 opened this issue Aug 21, 2024 · 10 comments
Closed
5 tasks

[Gallery][WASM] [Textbox] Unintended Text Selection #1459

jhanvi03 opened this issue Aug 21, 2024 · 10 comments
Assignees
Labels
area/canary kind/bug Something isn't working

Comments

@jhanvi03
Copy link

Current behavior

When switching from one component to another via the side menu and then returning to a textbox, the text within the textbox is occasionally pre-selected.

Screen.Recording.2024-08-21.at.11.58.54.AM.mov

Screenshot 2024-08-21 at 11 55 29 AM

Expected behavior

When returning to the textbox after navigating between components, the text should remain unselected

How to reproduce it (as minimally and precisely as possible)

  1. Open Gallery Canary WSM.
  2. From the side menu, expand UI Components and click on Textbox.
  3. Observe that no text is automatically selected in the textbox.
  4. Now, switch to a different component from the side menu, then return to the Textbox component.
  5. Notice that upon returning, the text in the textbox appears to be automatically selected.

Environment

Nuget Package:

Package Version(s):

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • UWP
  • MacOS

Anything else we need to know?

Could be related to : unoplatform/uno#17633 , unoplatform/uno#17914

@jhanvi03 jhanvi03 added the kind/bug Something isn't working label Aug 21, 2024
@MartinZikmund MartinZikmund pinned this issue Aug 26, 2024
@MartinZikmund MartinZikmund unpinned this issue Aug 26, 2024
@MartinZikmund MartinZikmund removed their assignment Aug 26, 2024
@MartinZikmund
Copy link
Member

@Youssef1313 @ramezgerges does this look familiar?

@ramezgerges
Copy link
Collaborator

This is actually a duplicate of unoplatform/uno#13440. The repro is not component switching, but double clicking. I suspect @jhanvi03 mistakenly double clicked on the "TextBox" item while switching between components.

@kazo0
Copy link
Collaborator

kazo0 commented Sep 3, 2024

@jhanvi03 can you double check this and maybe sync with @ramezgerges / @MartinZikmund to see if this is perhaps related to the double-click issue?

@jhanvi03
Copy link
Author

jhanvi03 commented Sep 9, 2024

Tested using mouse pad and mouse, occasionally I am able to reproduce with single click. Also, with double click on component, the entire section is getting selected.
Version:

Package Referenced version Updated version
Uno.Core.Extensions.Compatibility 4.0.1 4.1.1
Uno.Core.Extensions.Disposables 4.0.1 4.1.1
Uno.Sdk 5.3.96 5.4.0-dev.236

@jhanvi03 jhanvi03 removed their assignment Sep 16, 2024
@jhanvi03
Copy link
Author

Using the latest Canary version, I encountered the same issue when I navigated to Menu -> Community Toolkit -> DataGrid. Upon a single click, the data was selected unexpectedly.

Versions:
Package Referenced version Updated version
Uno.CommunityToolkit.WinUI.UI.Controls 7.1.200 7.1.203
Uno.CommunityToolkit.WinUI.UI.Controls.DataGrid 7.1.200 7.1.203
Uno.Core.Extensions.Compatibility 4.0.1 4.1.1
Uno.Core.Extensions.Disposables 4.0.1 4.1.1
Uno.Sdk 5.3.96 5.6.0-dev.16

Screenshot 2024-10-17 at 9 27 18 AM

@Kunal22shah
Copy link
Contributor

Kunal22shah commented Nov 25, 2024

Its not related to Component switching, but re clicking on the Textbox component and slightly moving the mouse (click and drag) causes the default text to get selected.
textbox- canaries

It seems to be introduced between 5.4.0-dev.198 and 5.4.0-dev.196 SDK versions

@Kunal22shah Kunal22shah changed the title [Gallery][WASM] Occasional Unintended Text Selection After Component Switch [Gallery][WASM] [Textbox] Unintended Text Selection Nov 25, 2024
@Xiaoy312 Xiaoy312 self-assigned this Nov 26, 2024
@dr1rrb
Copy link
Member

dr1rrb commented Nov 26, 2024

IMO this should be fixed by unoplatform/uno#18921 @Xiaoy312 did you validated it?

@Kunal22shah
Copy link
Contributor

IMO this should be fixed by unoplatform/uno#18921 @Xiaoy312 did you validated it?

@dr1rrb I tested on master w the latest changes from Xiao, unable to repro this now. (unoplatform/uno#18931)
pointer fixed

@Xiaoy312
Copy link
Contributor

Xiaoy312 commented Dec 3, 2024

@Kunal22shah
unable to repro at all (before and after), or
no longer repro with the fix?

@Kunal22shah
Copy link
Contributor

@Xiaoy312 no longer able to repro with your fix.

@Xiaoy312 Xiaoy312 closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/canary kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants