Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPF fails to build due to CS0433 when MSAL is included #2004

Closed
10 tasks
MartinZikmund opened this issue Sep 12, 2023 · 6 comments
Closed
10 tasks

WPF fails to build due to CS0433 when MSAL is included #2004

MartinZikmund opened this issue Sep 12, 2023 · 6 comments
Assignees
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.

Comments

@MartinZikmund
Copy link
Member

Current behavior

Trying to build

Expected behavior

How to reproduce it (as minimally and precisely as possible)

  • Run Wizard
  • Select Blank template and Customize
  • Add Skia WPF platform
  • Add MSAL authentication
  • Create
  • Try to build the solution
  • Build fails with C:\Dev\Throwaway\UnoApp17\UnoApp17.Skia.WPF\Uno.UI.SourceGenerators\Uno.UI.SourceGenerators.BindableTypeProviders.BindableTypeProvidersSourceGenerator\BindableMetadata.g.cs(13228,88,13228,100): error CS0433: The type 'CoreWebView2' exists in both 'Microsoft.Web.WebView2.Core, Version=1.0.864.35, Culture=neutral, PublicKeyToken=2a8ab48044d2601e' and 'Uno.UI, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null'

Environment

Nuget Package:

Package Version(s):

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renders for Xamarin.Forms
  • Windows
  • Build tasks

Visual Studio:

  • 2017 (version: )
  • 2019 (version: )
  • for Mac (version: )

Relevant plugins:

  • Resharper (version: )

Anything else we need to know?

@MartinZikmund MartinZikmund added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Sep 12, 2023
@MartinZikmund
Copy link
Member Author

CC @jeromelaban

@jeromelaban
Copy link
Member

That one is going to be difficult to fix, both types may effectively exist at the same time...

@nickrandolph
Copy link
Contributor

Is this an issue with the template or specifically with MSAL?
On the template, perhaps we should restrict targets to only those that we know work with MSAL?

@MartinZikmund
Copy link
Member Author

MartinZikmund commented Oct 20, 2023

@nickrandolph @jeromelaban maybe it would make sense to prevent selecting MSAL if WPF is also selected (at least for now). Otherwise we get bad user experience now with the solution not building out of the box. Or we find a way to implement MSAL on WPF without WebView2. @carldebilly might know?

@nickrandolph
Copy link
Contributor

Yeh I had this on my backlog for wizard/template to prevent msal if not supported platforms are selected. I just need to spend some time verifying which platforms are working.

@MartinZikmund MartinZikmund transferred this issue from unoplatform/uno.templates Nov 5, 2023
@nickrandolph
Copy link
Contributor

Closing as duplicate of unoplatform/uno.templates#426 where not supported platforms are included by template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.
Projects
None yet
Development

No branches or pull requests

4 participants