Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make solution-config.props.sample instructions clearer #424

Closed
MartinZikmund opened this issue Nov 9, 2023 · 0 comments · Fixed by #425
Closed

Make solution-config.props.sample instructions clearer #424

MartinZikmund opened this issue Nov 9, 2023 · 0 comments · Fixed by #425
Assignees
@nickrandolph
Labels
kind/enhancement New feature or request. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@MartinZikmund
Copy link
Member

MartinZikmund commented Nov 9, 2023 •
edited
Loading

It is not ok to uncomment multiple overrides at once, but the instructions are not clear about it. If .NE8 and .NET Mobile are both uncommented, it will break,
@MartinZikmund MartinZikmund added kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification. labels Nov 9, 2023
@nickrandolph nickrandolph mentioned this issue Nov 10, 2023
Merged
7 tasks
@nickrandolph nickrandolph added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed triage/untriaged Indicates an issue requires triaging or verification. labels Nov 10, 2023
@nickrandolph nickrandolph self-assigned this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickrandolph nickrandolph

Labels
kind/enhancement New feature or request. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Adjusting overrides to be single target and provide warnings unoplatform/uno.templates
2 participants
@MartinZikmund @nickrandolph