Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add config as requirement for http and loc #1128

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

eriklimakc
Copy link
Contributor

GitHub Issue (If applicable): closes #991

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Configuration is not added as requirement for Http and Localization, but i should.

What is the new behavior?

Configuration is added as requirement for Http and Localization.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@eriklimakc eriklimakc self-assigned this Nov 25, 2024
@kazo0 kazo0 merged commit eced940 into main Nov 26, 2024
65 checks passed
Copy link

welcome bot commented Nov 26, 2024

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

@eriklimakc
Copy link
Contributor Author

@Mergifyio backport release/stable/5.5

Copy link

mergify bot commented Nov 29, 2024

backport release/stable/5.5

✅ Backports have been created

jeromelaban added a commit that referenced this pull request Nov 29, 2024
….5/pr-1128

fix: Add config as requirement for http and loc (backport #1128)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants