Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf]Microsoft.UI.Xaml.Controls.BorderLayerRenderer.InnerCreateLayers(...) is slow on Android #10241

Closed
Tracked by #8597
ebariche opened this issue Oct 24, 2022 · 1 comment · Fixed by #10307
Closed
Tracked by #8597

[Perf]Microsoft.UI.Xaml.Controls.BorderLayerRenderer.InnerCreateLayers(...) is slow on Android #10241

ebariche opened this issue Oct 24, 2022 · 1 comment · Fixed by #10307
Assignees
@ebariche
Labels
area/performance 📈 Categorizes an issue or PR as relevant to performance difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working

Comments

@ebariche
Copy link
Member

Current behavior

We need to write specialized bindings for Brush.GetBackgroundDrawable(...) / BorderLayerRenderer.GetOverlayDrawable(...) as they consume over 6.65s of CPU time in some apps.

image

image

Expected behavior

No response

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

No response

Environment

No response

NuGet package version(s)

No response

Affected platforms

Android

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response
@ebariche ebariche added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. area/performance 📈 Categorizes an issue or PR as relevant to performance labels Oct 24, 2022
@ebariche ebariche self-assigned this Oct 24, 2022
@jeromelaban jeromelaban removed the triage/untriaged Indicates an issue requires triaging or verification label Oct 24, 2022
@jeromelaban jeromelaban mentioned this issue Oct 24, 2022
Open
71 tasks
@ebariche ebariche changed the title Microsoft.UI.Xaml.Controls.BorderLayerRenderer.InnerCreateLayers(...) is slow on Android [Perf][Android]Microsoft.UI.Xaml.Controls.BorderLayerRenderer.InnerCreateLayers(...) is slow Oct 24, 2022
@ebariche ebariche changed the title [Perf][Android]Microsoft.UI.Xaml.Controls.BorderLayerRenderer.InnerCreateLayers(...) is slow [Perf]Microsoft.UI.Xaml.Controls.BorderLayerRenderer.InnerCreateLayers(...) is slow on Android Oct 24, 2022
@MartinZikmund
Copy link
Member

MartinZikmund commented Oct 27, 2022 •
edited
Loading

I think this also includes has the same problem as border rendering on Skia where each time border changes a new radii array of length 8 is allocated #10260 (comment)

@ebariche ebariche mentioned this issue Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebariche ebariche

Labels
area/performance 📈 Categorizes an issue or PR as relevant to performance difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: Specialized bindings unoplatform/uno
3 participants
@MartinZikmund @jeromelaban @ebariche