Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce accesses of TextBlock.Inlines #13824

Open
Tracked by #8597
Youssef1313 opened this issue Sep 26, 2023 · 0 comments
Open
Tracked by #8597

Reduce accesses of TextBlock.Inlines #13824

Youssef1313 opened this issue Sep 26, 2023 · 0 comments
Labels
area/performance 📈 Categorizes an issue or PR as relevant to performance area/skia ✏️ Categorizes an issue or PR as relevant to Skia difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request

Comments

@Youssef1313
Copy link
Member

What would you like to be added

https://github.com/unoplatform/uno/blob/e8befba2450ba358c10e96cb6b263ffccaa294f1/src/Uno.UI/UI/Xaml/Controls/TextBlock/TextVisual.skia.cs#L34C11-L34C18

Inlines is accessed for every TextBlock that will be drawn. That has a significant negative performance impact.

Why is this needed

No response

For which platform

No response

Anything else we need to know?

No response
@Youssef1313 Youssef1313 added kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/performance 📈 Categorizes an issue or PR as relevant to performance labels Sep 26, 2023
@jeromelaban jeromelaban mentioned this issue Sep 14, 2023
Open
71 tasks
@MartinZikmund MartinZikmund added difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/performance 📈 Categorizes an issue or PR as relevant to performance area/skia ✏️ Categorizes an issue or PR as relevant to Skia difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MartinZikmund @Youssef1313