Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Build unit tests solution filter" step will pack Uno.UI.Adapter.Microsoft.Extensions.Logging unnecessarily #19272

Open
Youssef1313 opened this issue Jan 18, 2025 · 0 comments
Open

"Build unit tests solution filter" step will pack Uno.UI.Adapter.Microsoft.Extensions.Logging unnecessarily #19272

Youssef1313 opened this issue Jan 18, 2025 · 0 comments
Labels
area/build Categorizes an issue or PR as relevant to build infrastructure area/tests 🧪 Categorizes an issue or PR as relevant to tests difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Jan 18, 2025 •
edited
Loading

From step logs:

  The package Uno.UI.Adapter.Microsoft.Extensions.Logging.255.255.255.255 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package 'C:\a\1\s\src\Uno.UI.Adapter.Microsoft.Extensions.Logging\bin\Uno.UI.Adapter.Microsoft.Extensions.Logging\Release\Uno.UI.Adapter.Microsoft.Extensions.Logging.255.255.255.255.nupkg'.

This should be unnecessary.

In general, I do think that using GeneratePackageOnBuild is a bad idea. Instead, jobs that needs to produce packages should have an explicit pack step. This may be a broader refactoring to the CI.
@Youssef1313 Youssef1313 added area/build Categorizes an issue or PR as relevant to build infrastructure area/tests 🧪 Categorizes an issue or PR as relevant to tests difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification labels Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build Categorizes an issue or PR as relevant to build infrastructure area/tests 🧪 Categorizes an issue or PR as relevant to tests difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Youssef1313