Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using CreateFromStringAttribute breaks build #2398

Closed
4 of 11 tasks
SuperJMN opened this issue Dec 25, 2019 · 0 comments
Closed
4 of 11 tasks

Using CreateFromStringAttribute breaks build #2398

SuperJMN opened this issue Dec 25, 2019 · 0 comments
Assignees
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification

Comments

@SuperJMN
Copy link
Contributor

Current behavior

Using a class adorned with CreateFromStringAttribute and using it in XAML (as string) breaks all the heads (except UWP).

Expected behavior

The attribute should make the XAML parser instantiate an instance of the adorned class using the string provided in XAML

How to reproduce it (as minimally and precisely as possible)

  1. Extract this solution: Repro.zip
  2. Build and run for UWP: it will run perfectly
  3. Build and run for WASM and Android: the build is broken

Environment

Nuget Package:

Package Version(s):
2.1.0-dev.481

Affected platform(s):

Confirmed on Android and WebAssembly. iOS is likely to be affected, too.

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renderers for Xamarin.Forms
  • Windows
  • Build tasks
  • Solution Templates

Visual Studio:

  • 2017 (version: )
  • 2019 (version: )
  • for Mac (version: )

Relevant plugins:

  • Resharper (version: 2019.3.1)
@SuperJMN SuperJMN added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels Dec 25, 2019
@Massimo37 Massimo37 self-assigned this Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
Development

No branches or pull requests

2 participants