Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Resource generation fails when resw keys start with numbers or contains a '-' character #902

Closed
MakanWG opened this issue May 23, 2019 · 1 comment
Closed

[Android] Resource generation fails when resw keys start with numbers or contains a '-' character #902

MakanWG opened this issue May 23, 2019 · 1 comment
Labels
kind/bug Something isn't working platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform

Comments

@MakanWG
Copy link
Contributor

MakanWG commented May 23, 2019

Bug report

Current behavior

When a resource name starts by a number or contains a '-' the resource C# file generated by xamarin Android is full of unsuported variable names.

Expected behavior

This should work without renaming all the problematic variables

Minimal reproduction of the problem with instructions

STEPS TO REPRODUCE
Use a resw file to store strings. Add some ressources, and name some with just numbers.
Notice the build fails because of invalid variable names in the generated resources file.

Environment

Nuget Package: Uno.UI

Package Version(s): 1.44.1

Affected platform(s):
- [ ] iOS
- [x] Android
- [ ] WebAssembly
- [ ] Windows
- [ ] Build tasks

Visual Studio
- [x] 2017 (version: )
- [x] 2019 (version: )
- [x] for Mac (version: )
@MakanWG MakanWG mentioned this issue May 23, 2019
Merged
7 tasks
@MakanWG MakanWG changed the title Resource generation fails when resw keys start with numbers or contains a '-' character [Android] Resource generation fails when resw keys start with numbers or contains a '-' character May 23, 2019
@MakanWG MakanWG added the kind/bug Something isn't working label May 23, 2019
@ghuntley ghuntley added the platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform label May 23, 2019
@ghuntley
Copy link
Member

Resolved in #903

@jeromelaban jeromelaban mentioned this issue Oct 21, 2019
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ghuntley @MakanWG