-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Port Numbers without Protocols not Parsed #69
Comments
This changed with #22 but I would argue that it's not a breaking change but a bug fix. Node.js > url.parse('localhost:8000')
Url {
protocol: 'localhost:',
slashes: null,
auth: null,
host: '8000',
port: null,
hostname: '8000',
hash: null,
search: null,
query: null,
pathname: null,
path: null,
href: 'localhost:8000' } Firefox 54.0.1: new URL('localhost:8000')
URL { href: "localhost:8000", origin: "null", protocol: "localhost:", username: "", password: "", host: "", hostname: "", port: "", pathname: "8000", search: "" } |
@lpinca so this is the expected behavior? |
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems there was a breaking change to the way that port numbers are parsed. Take this example:
The current version (1.1.9) produces the following output:
When previous versions (1.0.5), produce this:
The text was updated successfully, but these errors were encountered: