Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RunBook]: Delete NAT Gateways #547

Closed
wants to merge 9 commits into from

Conversation

harshal-netserv
Copy link
Contributor

Description

Delete Unused NAT Gateways

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published.

Documentation

Make sure that you have documented corresponding changes in this repository.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

dougsillars
dougsillars previously approved these changes Apr 27, 2023
@amit-chandak-unskript
Copy link
Contributor

Dont think this runbook is using the right legos. @harshal-netserv we need to revisit this runbook. I will give more details later

Copy link
Contributor

@amit-chandak-unskript amit-chandak-unskript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont commit this

@amit-chandak-unskript
Copy link
Contributor

@shloka-bhalgat-unskript Please take care of the failing check for this PR

@shloka-bhalgat-unskript
Copy link
Member

Done @amit-chandak-unskript

@abhishek-unskript
Copy link
Member

Hi @shloka-bhalgat-unskript , is this PR ready to be reviewed again?

@shloka-bhalgat-unskript
Copy link
Member

@abhishek-unskript we don't need this runbook as it is a duplicate for this which is there in our cost-opt suite.

@shloka-bhalgat-unskript
Copy link
Member

Closing this PR.

@abhishek-unskript abhishek-unskript deleted the 538-runbook-delete-nat-gateways branch July 14, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RunBook]: Delete NAT Gateways
5 participants