-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow basic theme changes to be done from Django Admin #343
Comments
Hi @tuxology I'm trying to set up the repo in my local machine and I would like to work on these issues. Do I have to be assigned first to be able to work on this issues? |
You can begin working on this @untari I'll assign it to you. |
Hi @tuxology thanks! Will start working on it |
Hi @tuxology I figured the current workflow for now:
Can you please confirm this is the correct workflow, or if you suggest something different? I find I might need to create new API calls to pass the style values from the backend to the frontend, is this correct or is there a better way to pass those vales? Thanks! |
@untari Yes this is almost correct workflow. By extracting colors and styles, what I meant was carefully refactor the code and make these values configuration driven rather than being hardcoded in the code. Here is what I had in mind:
|
Updated: Sorry was thinking its per user. We could create a theme file with css variables. And we can have empty overrides file. If the Admin overrides any of the theme property, it could go into overrides file. In UI we load both theme and then overrides file in Admin interface we could actually show a preview of color or font changes. When user saves the theme we update the json blob Ui make an api call to fetch the user overrides and override the css values. It would be better if we use css variables and replace |
ZubHub currently uses 3 primary colors. There is also a pre-defined font family (Raleway). We want to allow the Zubhub users to change these values from the backend using the admin interface. There are few tasks we need to do to achieve this:
The text was updated successfully, but these errors were encountered: