Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage list in generator is one off #2

Open
stuartpb opened this issue Jan 15, 2018 · 1 comment
Open

Stage list in generator is one off #2

stuartpb opened this issue Jan 15, 2018 · 1 comment
Labels
bug Something isn't working tooling Tools for working with project definitions upstream Not my fault

Comments

@stuartpb
Copy link
Member

This is minor, but it does kind of irritate me: pressing "1" at the stage list selects stage 0, pressing "2" selects stage 1, and so on.

I've considered adding an "index" parameter to the question for inquirer to address this, but I'm not sure it's the most elegant solution - even though it'd solve my problem, I don't feel it'd be best of problems in general, so I'm choosing to just suck it up as-is for now. (If I used inquirer more, and had more use cases, I might implement a more robust reconfiguration, such as letting list selection be keyed-in by value, or having arbitrary key-in values, or showing values, or showing numbered indices...)

@stuartpb
Copy link
Member Author

Anyway, considering standard QWERTY keyboard number layout, this 1-indexing behavior is kind of most useful as-is, so... meh. Another reason I'm not really fighting this issue that much upstream.

@stuartpb stuartpb added bug Something isn't working upstream Not my fault tooling Tools for working with project definitions labels Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tooling Tools for working with project definitions upstream Not my fault
Projects
None yet
Development

No branches or pull requests

1 participant