Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move function-p&t from upbound to crossplane-contrib #20

Closed
wants to merge 1 commit into from

Conversation

djeremiah
Copy link

Description of your changes

The Upbound fork of function-patch-and-transform has been retired. This PR moves the composition to the crossplane-contrib repository

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

  • Run make render to confirm the composition renders correctly

@haarchri
Copy link
Member

/test-examples

…function-patch-and-transform

Signed-off-by: Murph <murph@opusdavei.org>
@humoflife
Copy link
Collaborator

/test-examples

@humoflife
Copy link
Collaborator

Uptest failed in the resource deletion step after 1+ hour.

@haarchri
Copy link
Member

@humoflife looks like an problem with ordered deletion:

- apiVersion: generic.vault.upbound.io/v1alpha1
  kind: Endpoint
[...]
    conditions:
    - lastTransitionTime: "2024-02-16T15:58:17Z"
      reason: Deleting
      status: "False"
      type: Ready
    - lastTransitionTime: "2024-02-16T16:00:10Z"
      message: 'connect failed: cannot get terraform setup: cannot extract credentials:
        cannot get credentials secret: Secret "vault-creds" not found'
      reason: ReconcileError
      status: "False"
      type: Synced
- apiVersion: auth.vault.upbound.io/v1alpha1
  kind: Backend
[...]
    conditions:
    - lastTransitionTime: "2024-02-16T15:58:18Z"
      reason: Available
      status: "True"
      type: Ready
    - lastTransitionTime: "2024-02-16T16:08:18Z"
      message: 'connect failed: cannot get terraform setup: cannot extract credentials:
        cannot get credentials secret: Secret "vault-creds" not found'
      reason: ReconcileError
      status: "False"
      type: Synced

@humoflife humoflife closed this Feb 22, 2024
@humoflife
Copy link
Collaborator

humoflife commented Feb 22, 2024

Closing because of another PR that moves the functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants