Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backport): caas backport #44

Merged
merged 4 commits into from
Oct 30, 2023
Merged

feat(backport): caas backport #44

merged 4 commits into from
Oct 30, 2023

Conversation

haarchri
Copy link
Member

Description of your changes

followup for #42

  • backport from caas
  • update
    • XAKS
      • add region as input
      • add providerConfig as input
    • XCluster
      • add region as input
      • add providerConfig as input
      • using patchSets
    • XNetwork
    • XService
      • add flux
      • use prometheus as default
  • enable usages for XAKS, XServices and XApp
  • switch crossplane.yaml to root folder

Fixes #

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

@haarchri
feat(backport): caas backport
404565e 
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@haarchri haarchri mentioned this pull request Oct 29, 2023
Closed
3 tasks
@haarchri
Copy link
Member Author

/test-examples

@haarchri haarchri requested a review from ytsarev October 29, 2023 10:51
ytsarev
ytsarev reviewed Oct 29, 2023
View reviewed changes
Copy link
Member

@ytsarev ytsarev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments to discuss

apis/database/sqlinstance/definition.yaml Outdated Show resolved Hide resolved
apis/app/definition.yaml Show resolved Hide resolved
apis/cluster/services/flux/composition.yaml Show resolved Hide resolved
apis/cluster/services/flux/composition.yaml Show resolved Hide resolved
@haarchri
style(doc): add comments
012f34a 
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@haarchri
style(doc): add comments
23c7149 
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@haarchri haarchri requested a review from ytsarev October 30, 2023 15:19
ytsarev
ytsarev reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spotted another set of minor indentation issues, otherwise looks good

apis/app/definition.yaml Outdated Show resolved Hide resolved
apis/cluster/network/definition.yaml Outdated Show resolved Hide resolved
apis/cluster/services/definition.yaml Outdated Show resolved Hide resolved
@haarchri
style(doc): add comments
feeb5ba 
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
ytsarev
ytsarev approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the fixes 👍

@haarchri haarchri merged commit 38d0d15 into upbound:main Oct 30, 2023
1 check passed
@haarchri haarchri deleted the feature/backport branch October 30, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytsarev ytsarev ytsarev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haarchri @ytsarev