Add memorydb _user #1170
Merged
Add memorydb _user #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-examples="examples/memorydb/v1beta1/user.yaml" |
3 tasks
|
/test-examples="examples/memorydb/v1beta1/user.yaml" |
stevendborrelli
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
|
Thanks for the PR @stevendborrelli. It looks like the uptest bump and fix to the elasticache user has already been merged in a different PR. Can you please rebase on the latest main? |
Signed-off-by: Steven Borrelli <steve@borrelli.org>
Signed-off-by: Steven Borrelli <steve@borrelli.org>
Signed-off-by: Steven Borrelli <steve@borrelli.org>
Signed-off-by: Steven Borrelli <steve@borrelli.org>
stevendborrelli
force-pushed
the
memorydb_user
branch
from
f5dd435
to
803221c
Compare
Signed-off-by: Steven Borrelli <steve@borrelli.org>
|
Rebased and updated generated files. |
|
/test-examples="examples/memorydb/v1beta1/user.yaml" |
turkenf
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Thank you @stevendborrelli, LGTM.
It would be great if you remove the resource from externalnamenottested.go before merging.
Signed-off-by: Steven Borrelli <steve@borrelli.org>
|
@turkenf removed the entry from external names. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add memorydb user.
Fixes #1149, #368
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
With uptest: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/8444367117