fix(services): normalised fetch methods

`patch` could failed with lowercase method name

Author: nandi95

src/Calliope/Concerns/CallsApi.ts

@@ -11,7 +11,10 @@ import { isObjectLiteral } from '../../Support/function';
 import { finish, kebab, plural } from '../../Support/string';
 import type { MaybeArray } from '../../Support/type';
 
-export type Method = 'delete' | 'get' | 'patch' | 'post' | 'put';
+/**
+ * The request methods.
+ */
+export type Method = 'DELETE' | 'delete' | 'GET' | 'get' | 'PATCH' | 'patch' | 'POST' | 'post' | 'PUT' | 'put';
 
 export default class CallsApi extends BuildsQuery {
     /**

src/Services/API.ts

@@ -59,7 +59,7 @@ export default class API implements ApiCaller {
      * Prepare/compile the ajax call initialisation.
      *
      * @param {string} url - The endpoint the request goes to.
-     * @param {'get' | 'post' | 'delete' | 'patch' | 'put'} method - The method the request uses.
+     * @param {Method} method - The method the request uses.
      * @param {object=} data - The optional data to send with the request.
      * @param {object=} customHeaders - Custom headers to merge into the request.
      * @param {object=} queryParameters - The query parameters to append to the url
@@ -75,7 +75,8 @@ export default class API implements ApiCaller {
         customHeaders?: Record<string, MaybeArray<string>>,
         queryParameters?: Record<string, unknown>
     ): Promise<{ url: string; requestInit: RequestInit }> {
-        const initOptions: RequestInit = { method: method.toLowerCase() };
+        // normalising fetch methods https://fetch.spec.whatwg.org/#concept-method-normalize
+        const initOptions: RequestInit = { method: method.toUpperCase() };
         const configHeaders = new Headers(new GlobalConfig().get('headers'));
         queryParameters = queryParameters ?? {};
 
@@ -100,17 +101,17 @@ export default class API implements ApiCaller {
 
         // ensure method is explicitly set if previously
         // removed by initRequest or requestOptions
-        initOptions.method = initOptions.method ?? 'get';
+        initOptions.method = initOptions.method ?? 'GET';
 
-        if (initOptions.method === 'get') {
+        if (initOptions.method === 'GET') {
             // given if there was any body it was merged in above,
             // we delete it as GET cannot have a body
             delete initOptions.body;
         }
 
         if (isObjectLiteral(data) && Object.keys(data).length || data instanceof FormData) {
             // if not a GET method
-            if (initOptions.method && initOptions.method !== 'get') {
+            if (initOptions.method && initOptions.method !== 'GET') {
                 if (data instanceof FormData) {
                     if (!headers.has('Content-Type')) {
                         headers.set('Content-Type', 'multipart/form-data');