Bypass email validation for deleted emails

Author: Megamind51

src/asserts/email-assert.js

@@ -7,6 +7,17 @@
 const { Assert: is, Validator, Violation } = require('validator.js');
 let validator;
 
+/**
+ * Deleted email regex.
+ *
+ * The email should contain the following pattern:
+ * .+@any-word.any-word.any-number.deleted
+ *
+ * example: a@foo.com.123.deleted
+ */
+
+const regex = /.+@.+\.\d+\.deleted$/;
+
 /**
  * Optional peer dependencies.
  */
@@ -41,16 +52,26 @@ module.exports = function emailAssert() {
       throw new Violation(this, value, { value: Validator.errorCode.must_be_a_string });
     }
 
-    if (!validator.isEmail(value)) {
-      throw new Violation(this, value);
-    }
-
     try {
       is.ofLength({ max: 254 }).validate(value);
     } catch (e) {
       throw new Violation(this, value);
     }
 
+    // We are bypassing the email validation for deleted users.
+    // This is needed because we have legacy users with invalid emails
+    // and as part of the deletion flow for expired signups we need to allow
+    // the deletion of that kind of users. The process of deleting an
+    // user changes their email from user.email to
+    // ${user.email}.${timestamp}.deleted so this assert runs on that update.
+    if (regex.test(value) === true) {
+      return true;
+    }
+
+    if (!validator.isEmail(value)) {
+      throw new Violation(this, value);
+    }
+
     return true;
   };
 

test/asserts/email-assert.test.js

@@ -59,8 +59,35 @@ describe('EmailAssert', () => {
     }
   });
 
+  it('should thrown an error on invalid emails', () => {
+    [
+      '@foo.com.123.deleted',
+      'foo@.com',
+      'foo@.com.123.deleted',
+      'føø@båz.',
+      'føø@båz..123.deleted',
+      'foo+bar@baz_foo.com',
+      'foo+bar@baz_foo.com.12345.deleted'
+    ].forEach(choice => {
+      try {
+        Assert.prototype.Email().validate(choice);
+
+        fail();
+      } catch (e) {
+        expect(e.show().assert).toBe('Email');
+      }
+    });
+  });
+
   it('should accept valid emails', () => {
-    ['foo@bar.com', 'føø@båz.com', 'foo+bar@baz.com'].forEach(choice => {
+    [
+      'foo@bar.com',
+      'foo@bar.com.123.deleted',
+      'føø@båz.com',
+      'føø@båz.com.123.deleted',
+      'foo+bar@baz.com',
+      'foo+bar@baz.com.12345.deleted'
+    ].forEach(choice => {
       Assert.prototype.Email().validate(choice);
     });
   });