fix(uploader): replace IE unsupported ChildNode.remove method #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeetiss
approved these changes
Aug 14, 2020
|
@henrymyers thanks for fix! |
|
That should be fine. Thanks! |
|
@jeetiss Our PM asked if we could push our Uploadcare feature to prod today or tomorrow, so is there any way you could release the IE fix before Wednesday? Sorry for flip-flopping after my answer last week! |
|
@shipjs prepare |
|
@henrymyers ok |
|
@jeetiss |
|
@henrymyers release is ready, I hope that your PM will be happy today ❤️ |
|
Thanks! You must personally have great media queries in your mind, because you're waaaaaay responsive 😆 |
|
Sorry, couldn't hold the dad joke in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ChildNode.remove method is unsupported in IE, causing crashes when react-widget unmounts.
Fixed by using the common alternative
element.parentNode.removeChild(element).Checklist
Tests (if applicable)Documentation (if applicable)