add publicKeyJwk as valid verificationMethod #1096
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential missing of
verificationMethod.publicKeyJwk
ingetEthereumAddress()
Otherwise without this the method doesn't callextractPublicKeyBytes()
that is able to manage this type ofVerificationMethod
.Linking to an issue provides some context and a reason for the PR to be reviewed, as well as simplifying the release
notes and changelogs that get generated automatically. If an issue is linked like this it will be automatically closed
when the PR is merged.
What is being changed
A clear description of what this PR brings.
Quality
Check all that apply:
yarn
,yarn build
,yarn test
,yarn test:browser
locally.Details
If applicable, add screen captures, error messages or stack traces to help explain your problem.