Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly export PickupRecipientMessageHandler #1121

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

nickreynolds
Copy link
Contributor

What issue is this PR fixing

Recent DIDComm Mediator work was actually missing 2 exports :)

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because _________, and I am aware that a PR without tests will likely get rejected.

@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Base: 80.25% // Head: 84.65% // Increases project coverage by +4.40% 🎉

Coverage data is based on head (11ee872) compared to base (125bf42).
Patch coverage: 81.35% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1121      +/-   ##
==========================================
+ Coverage   80.25%   84.65%   +4.40%     
==========================================
  Files         118      145      +27     
  Lines        4056    14801   +10745     
  Branches      875     1548     +673     
==========================================
+ Hits         3255    12530    +9275     
- Misses        798     2271    +1473     
+ Partials        3        0       -3     
Impacted Files Coverage Δ
packages/core-types/src/agent.ts 0.00% <0.00%> (ø)
packages/core-types/src/coreEvents.ts 0.00% <ø> (ø)
packages/core-types/src/index.ts 0.00% <0.00%> (ø)
...s/credential-ld/src/module-types/jsonld/index.d.ts 0.00% <0.00%> (ø)
packages/data-store-json/src/types.ts 0.00% <0.00%> (ø)
...ackages/did-provider-ethr/src/ethr-did-provider.ts 87.09% <ø> (+3.76%) ⬆️
packages/did-provider-ethr/src/index.ts 100.00% <ø> (ø)
packages/did-provider-ethr/src/kms-eth-signer.ts 69.73% <ø> (-8.05%) ⬇️
packages/did-provider-ion/src/functions.ts 95.68% <ø> (ø)
packages/did-provider-ion/src/index.ts 100.00% <ø> (ø)
... and 215 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mirceanis mirceanis merged commit 3a7a086 into next Feb 13, 2023
@mirceanis mirceanis deleted the nickreynolds/export-pickup branch February 13, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants