Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add did:pkh support to the default CLI config #1133

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

mirceanis
Copy link
Member

What issue is this PR fixing

This adds support for did:pkh to the default CLI config.

> veramo did create
##  choose: did:pkh
> veramo did resolve did:pkh:eip155.....
## resolves a did:pkh

This also cleans some CLI initialization code and inline docs related to config loading.

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests unrelated to did:pkh.
  • I added integration tests.
  • I did not add relevant automated tests because there is still an incompatibility between the CLI tests and Jest.

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 80.25% // Head: 85.45% // Increases project coverage by +5.20% 🎉

Coverage data is based on head (722a6a1) compared to base (125bf42).
Patch coverage: 83.82% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1133      +/-   ##
==========================================
+ Coverage   80.25%   85.45%   +5.20%     
==========================================
  Files         118      145      +27     
  Lines        4056    14906   +10850     
  Branches      875     1561     +686     
==========================================
+ Hits         3255    12738    +9483     
- Misses        798     2168    +1370     
+ Partials        3        0       -3     
Impacted Files Coverage Δ
packages/core-types/src/coreEvents.ts 100.00% <ø> (ø)
...s/credential-ld/src/module-types/jsonld/index.d.ts 0.00% <0.00%> (ø)
packages/data-store-json/src/types.ts 0.00% <0.00%> (ø)
packages/did-comm/src/didcomm.ts 83.26% <ø> (+10.12%) ⬆️
packages/did-comm/src/index.ts 100.00% <ø> (ø)
packages/did-comm/src/message-handler.ts 72.10% <ø> (+12.64%) ⬆️
.../protocols/coordinate-mediation-message-handler.ts 89.63% <ø> (ø)
packages/did-comm/src/protocols/index.ts 100.00% <ø> (ø)
...omm/src/protocols/messagepickup-message-handler.ts 91.25% <ø> (ø)
.../did-comm/src/protocols/routing-message-handler.ts 89.65% <ø> (ø)
... and 209 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mirceanis mirceanis merged commit 19cccc1 into next Feb 24, 2023
@mirceanis mirceanis deleted the add-pkh-to-cli-default branch February 24, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants