Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this PR fixing
Example:
closes #1135
fixes #1136
What is being changed
The way
publicKeyHex
was computed forSecp256r1
keys was not correct, as the parity prefix was getting removed.This PR fixes that problem and proposes a method for updating existing keys:
https://github.com/uport-project/veramo/blob/663f4b206ec2470126d5b423340045788dbcb3da/__tests__/data.migration.test.ts#L48
The method still has to be invoked manually, but it should be fairly easy to add just before a
createAgent
call, since all the other classes(KeyManagementSystem, KeyStore, PrivateKeyStore, encryption keys) and data should be available.This also updates the JWK utils code that was inventing a parity prefix to the public keys, but would have worked only 50% of the time.
Quality
Check all that apply:
pnpm i
,pnpm build
,pnpm test
,pnpm test:browser
locally.