Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(cli): fix credential verify command for JWT credentials #1148

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

mirceanis
Copy link
Member

What issue is this PR fixing

This is a hotfix for a bug in the @veramo/cli package that is preventing proper credential verification for JWT-VC.

What is being changed

@veramo/cli credential verify command would try to parse a JWT credential and coerce it into a JSON format without doing the same kind of parsing that did-jwt-vc would do when verifying.
This caused the @veramo/credential-w3c package to then refuse the verification because of the mismatch between the JSON and the JWT payload.

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.

@mirceanis mirceanis changed the title fix(cli): fix credential verify command for JWT credentials hotfix(cli): fix credential verify command for JWT credentials Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2a0aef1) 85.27% compared to head (d7e4175) 85.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1148   +/-   ##
=======================================
  Coverage   85.27%   85.27%           
=======================================
  Files         149      149           
  Lines       15283    15285    +2     
  Branches     1615     1615           
=======================================
+ Hits        13032    13034    +2     
  Misses       2251     2251           
Impacted Files Coverage Δ
packages/credential-w3c/src/action-handler.ts 82.15% <100.00%> (+0.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mirceanis mirceanis merged commit 697a14c into main Mar 16, 2023
@mirceanis mirceanis deleted the hotfix-cli-credential-verification branch March 16, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants