fix(credential-ld): fix Ed25519Signature2020 verification #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o bytes, rename util function
* fix(utils): fix typo in key comparison * fix(credential-ld): pre-process DID doc for Ed25519Signature2020 * feat(credential-ld): add more granularity to the documentLoader for DID docs * feat(utils): test multibase/multicoded for ed25519 keys * fix(credential-ld): return correct signature bytes for Ed25519-2020 suite
mirceanis
commented
Apr 14, 2023
| }) | ||
| return u8a.fromString(signature) | ||
| return base64ToBytes(signature) |
There was a problem hiding this comment.
This was the culprit of signature verification failures
| } | ||
|
|
||
| // this signature suite requires the document loader to dereference the DID URL | ||
| if (didUrl.includes('#') && didUrl !== document.id) { |
There was a problem hiding this comment.
This is the workaround for the very strict documentLoader requirements.
mirceanis
force-pushed
the
nickreynolds/multibase-key-fixes
branch
from
972cf74 to
d8e0530
Compare
nickreynolds
approved these changes
Apr 14, 2023
|
Nice work getting to the bottom of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this PR fixing
This fixes the Ed25519Signature2020 signature verification.
What is being changed
This PR fixes several issues with the suite:
@contextandpublicKeyMultibaseto be set on the verification method used for verificationThis PR also cleans the default contexts and adds a
schema.org@contextas well.Quality
Check all that apply:
pnpm i,pnpm build,pnpm test,pnpm test:browserlocally.closes #1146