Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exporting didcomm mediator utils #1181

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Conversation

simonas-notcat
Copy link
Contributor

What is being changed

  • Exports @veramo/did-comm mediator utility methods
  • Changes debug message format in the agent.execute method to be more readable

old:

veramo:agent:resolveDid {didUrl: 'did:web:dev-didcomm-mediator.herokuapp.com'} 
veramo:agent:resolveDid:result {didDocumentMetadata: {…}, didResolutionMetadata: {…}, didDocument: {…}}

new:

veramo:agent:resolveDid arg {didUrl: 'did:web:dev-didcomm-mediator.herokuapp.com'} 
veramo:agent:resolveDid res {didDocumentMetadata: {…}, didResolutionMetadata: {…}, didDocument: {…}}

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because _________, and I am aware that a PR without tests will likely get rejected.

Details

If applicable, add screen captures, error messages or stack traces to help explain your problem.

@simonas-notcat simonas-notcat requested a review from mirceanis June 1, 2023 12:29
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 85.85% and project coverage change: +3.27 🎉

Comparison is base (125bf42) 80.25% compared to head (3b0b8b8) 83.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1181      +/-   ##
==========================================
+ Coverage   80.25%   83.52%   +3.27%     
==========================================
  Files         118      167      +49     
  Lines        4056    17050   +12994     
  Branches      875     1849     +974     
==========================================
+ Hits         3255    14241   +10986     
- Misses        798     2809    +2011     
+ Partials        3        0       -3     
Impacted Files Coverage Δ
packages/core-types/src/coreEvents.ts 100.00% <ø> (ø)
...s/credential-ld/src/module-types/jsonld/index.d.ts 0.00% <0.00%> (ø)
...data-store-json/src/browser-local-storage-store.ts 25.27% <ø> (+21.42%) ⬆️
packages/data-store-json/src/data-store-json.ts 91.55% <ø> (+6.44%) ⬆️
...ckages/data-store-json/src/identifier/did-store.ts 92.52% <ø> (+3.16%) ⬆️
...ckages/data-store-json/src/identifier/key-store.ts 86.84% <ø> (+10.37%) ⬆️
...ata-store-json/src/identifier/private-key-store.ts 94.11% <ø> (+5.48%) ⬆️
packages/data-store-json/src/index.ts 100.00% <ø> (ø)
packages/data-store-json/src/types.ts 0.00% <ø> (ø)
packages/data-store/src/data-store-orm.ts 90.39% <ø> (+17.25%) ⬆️
... and 76 more

... and 81 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mirceanis mirceanis merged commit 264b6a7 into next Jun 5, 2023
@mirceanis mirceanis deleted the feat/didcomm-mediator-utils branch June 5, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants