Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for publicKeyJwk #1194

Conversation

andyv09
Copy link
Contributor

@andyv09 andyv09 commented Jul 3, 2023

What issue is this PR fixing

Adds support for publicKeyJwk and fixes issue 'key not found in document' when using did:jwk

What is being changed

Changes structure of if statement (makes it more readable) in compareBlockchainAccountId and adds JsonWebKey2020 to said if statement.

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because _________, and I am aware that a PR without tests will likely get rejected.

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mirceanis mirceanis merged commit 9110688 into decentralized-identity:next Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants