Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package-lock.json #9

Closed
hyunjiLeeTech opened this issue Oct 14, 2020 · 2 comments · Fixed by #10
Closed

Add package-lock.json #9

hyunjiLeeTech opened this issue Oct 14, 2020 · 2 comments · Fixed by #10
Assignees
@hyunjiLeeTech
Labels
documentation Improvements or additions to documentation hacktoberfest-accepted

Comments

@hyunjiLeeTech
Copy link
Contributor

hyunjiLeeTech commented Oct 14, 2020 •
edited
Loading

There's no package-lock.json file in this project so users need to install modules manually checking what modules are needed for this project. It would be better if package-lock.json file is included on this project so users can simply install modules when they enter 'npm install'.
I would like to take this and update the README file as well.
@upsetdog
Copy link
Owner

oh yes go for it, thank u

@upsetdog upsetdog assigned upsetdog and hyunjiLeeTech and unassigned upsetdog Oct 14, 2020
@upsetdog upsetdog added documentation Improvements or additions to documentation hacktoberfest-accepted labels Oct 14, 2020
@hyunjiLeeTech
Copy link
Contributor Author

I've done this. Can you please check my pull request?

@upsetdog upsetdog linked a pull request Oct 15, 2020 that will close this issue
Issue 9 #10
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyunjiLeeTech hyunjiLeeTech

Labels
documentation Improvements or additions to documentation hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 9
2 participants
@hyunjiLeeTech @upsetdog