Skip to content

Commit 77b8f64

Browse files
committed
feat: make the list edit forms full height
1 parent 49ff33a commit 77b8f64

File tree

3 files changed

+19
-23
lines changed

3 files changed

+19
-23
lines changed

src/components/databrowser/components/display/display-list-edit.tsx

Lines changed: 17 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -80,31 +80,22 @@ const ListEditForm = ({
8080

8181
return (
8282
<FormProvider {...form}>
83-
<form onSubmit={onSubmit} className="flex flex-col gap-2">
83+
<form onSubmit={onSubmit} className="flex h-full flex-col gap-2">
8484
<div className="flex grow flex-col gap-2">
85+
{type === "zset" && <NumberFormItem name="value" label={valueLabel} />}
86+
8587
{type !== "list" && (
88+
<FormItem readOnly={type === "stream"} name="key" label={keyLabel} data={itemKey} />
89+
)}
90+
91+
{type !== "set" && type !== "zset" && (
8692
<FormItem
8793
readOnly={type === "stream"}
88-
name="key"
89-
height={type === "set" ? 250 : 100}
90-
label={keyLabel}
91-
data={itemKey}
94+
name="value"
95+
label={valueLabel}
96+
data={itemValue ?? ""}
9297
/>
9398
)}
94-
95-
{type === "zset" ? (
96-
<NumberFormItem name="value" label={valueLabel} />
97-
) : (
98-
type !== "set" && (
99-
<FormItem
100-
readOnly={type === "stream"}
101-
name="value"
102-
height={type === "list" ? 250 : 100}
103-
label={valueLabel}
104-
data={itemValue ?? ""}
105-
/>
106-
)
107-
)}
10899
</div>
109100

110101
<div
@@ -195,14 +186,19 @@ const FormItem = ({
195186
})
196187

197188
return (
198-
<div className="flex flex-col gap-1">
189+
<div className={cn("flex flex-col gap-1", !height && "h-full")}>
199190
<div className="flex items-center gap-1 text-xs">
200191
<span className="font-medium text-zinc-700">{label}</span>{" "}
201192
<span className="text-zinc-300">/</span>
202193
{selector}
203194
</div>
204195

205-
<div className="overflow-hidden rounded-md border border-zinc-300 bg-white p-2 shadow-sm">
196+
<div
197+
className={cn(
198+
"overflow-hidden rounded-md border border-zinc-300 bg-white p-2 shadow-sm",
199+
!height && "h-full"
200+
)}
201+
>
206202
{editor}
207203
</div>
208204
</div>

src/components/databrowser/components/display/display-simple.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ const EditorDisplayForm = ({
6363
{type === "json" ? <div /> : selector}
6464
</div>
6565

66-
<div className="grow rounded-md border border-zinc-300 bg-white p-1">{editor}</div>
66+
<div className="grow rounded-md border border-zinc-300 bg-white p-2">{editor}</div>
6767
</div>
6868

6969
<div className="flex shrink-0 items-center gap-2">

src/components/databrowser/components/display/input/custom-editor.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export const CustomEditor = ({
7474

7575
return (
7676
<div
77-
className={cn("group/editor relative", height === undefined && "h-full p-2")}
77+
className={cn("group/editor relative", height === undefined && "h-full")}
7878
style={{ height: height }}
7979
>
8080
{isTest ? (

0 commit comments

Comments
 (0)