Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch stdout thrown on assert raises for strictio #69

Open
mmckerns opened this issue Nov 27, 2014 · 4 comments
Open

catch stdout thrown on assert raises for strictio #69

mmckerns opened this issue Nov 27, 2014 · 4 comments
Labels

Comments

@mmckerns
Copy link
Member

From #57, In test/test_file.py, when strictio=True, stdout is generated -- roughly corresponding to each of the assert using throws. This should be trapped. Further, if stdout is thrown from dill (but not errors) in these cases, that should also be trapped.

@mmckerns mmckerns added the bug label Nov 27, 2014
@mmckerns mmckerns added this to the dill-0.2.2 milestone Nov 27, 2014
@mmckerns mmckerns changed the title catch stdout thrown in test_file catch stdout thrown by assert raises in test_file Nov 28, 2014
@mmckerns mmckerns changed the title catch stdout thrown by assert raises in test_file catch stdout thrown on assert raises for strictio Nov 28, 2014
@mmckerns
Copy link
Member Author

disabled strictio in 1fa9cef. Leaving this open, as bug is still present when strictio is enabled.

@mmckerns mmckerns modified the milestones: dill-0.2.3, dill-0.2.2 Nov 28, 2014
@mmckerns
Copy link
Member Author

may be able to shunt error to another subprocess

@matsjoyce
Copy link
Contributor

Another option that I've used before is unittest.TextTestRunner(verbosity=2, buffer=True).run(tests), which only displays output if the corresponding test fails. That would need to wait for #3, though.

@mmckerns
Copy link
Member Author

mmckerns commented Dec 2, 2014

good point.

BTW: I've disabled strictio only very temporarily… soon as the release is out, I'll enable it again but with this error handled.

@mmckerns mmckerns modified the milestones: dill-0.2.4, dill-0.2.3 Jun 22, 2015
@mmckerns mmckerns modified the milestones: dill-0.2.4, dill-0.2.5 Jul 29, 2015
@mmckerns mmckerns modified the milestones: dill-0.2.5, dill-0.2.6 Feb 6, 2016
@mmckerns mmckerns modified the milestones: dill-0.2.6, dill-0.2.7 Feb 1, 2017
@mmckerns mmckerns modified the milestones: dill-0.2.8, dill-0.2.7 Jul 8, 2017
@mmckerns mmckerns modified the milestones: dill-0.2.8, dill-0.2.9 Jun 22, 2018
@mmckerns mmckerns removed this from the dill-0.2.9 milestone Jan 20, 2019
@mmckerns mmckerns added this to the dill-0.3.0 milestone Jan 20, 2019
@mmckerns mmckerns removed this from the dill-0.3.0 milestone Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants