Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): improve TypeScript type definitions #378

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

josh-cloudscape
Copy link
Contributor

@josh-cloudscape josh-cloudscape commented Jul 6, 2022

Fixes #373 (as well as other issues)

Copy link
Member

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks @josh-cloudscape 👍

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #378 (16da386) into main (e24c6b4) will not change coverage.
The diff coverage is n/a.

❗ Current head 16da386 differs from pull request most recent head 79ed110. Consider uploading reports for the commit 79ed110 to get more accurate results

@@           Coverage Diff           @@
##             main     #378   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files          26       26           
  Lines         725      725           
  Branches      180      180           
=======================================
  Hits          713      713           
  Misses          8        8           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e24c6b4...79ed110. Read the comment docs.

@stepankuzmin stepankuzmin merged commit 6ceb87e into urbica:main Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong typing for <Marker> component
2 participants