Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update isBrowser check #387

Merged
merged 1 commit into from
Jul 9, 2022
Merged

fix: update isBrowser check #387

merged 1 commit into from
Jul 9, 2022

Conversation

stepankuzmin
Copy link
Member

Update isBrowser check to support Electron environment

Closes #307 #371

@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #387 (9c38124) into main (1adf9a6) will decrease coverage by 0.37%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
- Coverage   98.34%   97.96%   -0.38%     
==========================================
  Files          26       28       +2     
  Lines         725      738      +13     
  Branches      180      189       +9     
==========================================
+ Hits          713      723      +10     
- Misses          8       11       +3     
  Partials        4        4              
Impacted Files Coverage Δ
src/utils/mapbox-gl.js 100.00% <ø> (ø)
src/utils/isElectron.js 72.72% <72.72%> (ø)
src/utils/isBrowser.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1adf9a6...9c38124. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/react-map-gl.cjs.js 9.61 KB (+0.99% 🔺) 193 ms (+0.99% 🔺) 38 ms (+65.46% 🔺) 230 ms
dist/react-map-gl.esm.js 9.72 KB (+1.05% 🔺) 195 ms (+1.05% 🔺) 22 ms (-20.41% 🔽) 216 ms

@stepankuzmin stepankuzmin force-pushed the fix-browser-detection branch from d092ac6 to 9c38124 Compare July 9, 2022 09:08
@stepankuzmin stepankuzmin merged commit 82ee39a into main Jul 9, 2022
@stepankuzmin stepankuzmin deleted the fix-browser-detection branch July 9, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'isBrowser' check in utils/mapbox-gl prevents rendering in Electron
1 participant