Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use undefined as default Popup props #402

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conversation

stepankuzmin
Copy link
Member

@stepankuzmin stepankuzmin commented Jul 19, 2022

@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/react-map-gl.cjs.js 7.58 KB (+0.06% 🔺) 152 ms (+0.06% 🔺) 21 ms (-46.89% 🔽) 173 ms
dist/react-map-gl.esm.js 7.61 KB (+0.06% 🔺) 153 ms (+0.06% 🔺) 24 ms (-25.78% 🔽) 177 ms

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #402 (22c370f) into main (566ac64) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #402   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files          28       28           
  Lines         738      738           
  Branches      189      189           
=======================================
  Hits          723      723           
  Misses         11       11           
  Partials        4        4           
Impacted Files Coverage Δ
src/components/Popup/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566ac64...22c370f. Read the comment docs.

@stepankuzmin stepankuzmin changed the title fix: use undefined as Popup default props fix: use undefined as default Popup props Jul 19, 2022
@stepankuzmin stepankuzmin merged commit d08f0c5 into main Jul 19, 2022
@stepankuzmin stepankuzmin deleted the fix-Popup-defaults branch July 19, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant