Merge pull request #2224 from dearchap/issue_2223

Fix:(issue_2223) Fix incorrect processing of empty value after =

Author: dearchap

command_parse.go

@@ -136,10 +136,12 @@ func (cmd *Command) parseFlags(args Args) (Args, error) {
 
 		flagName := firstArg[numMinuses:]
 		flagVal := ""
+		valFromEqual := false
 		tracef("flagName:1 (fName=%[1]q)", flagName)
 		if index := strings.Index(flagName, "="); index != -1 {
 			flagVal = flagName[index+1:]
 			flagName = flagName[:index]
+			valFromEqual = true
 		}
 
 		tracef("flagName:2 (fName=%[1]q) (fVal=%[2]q)", flagName, flagVal)
@@ -162,7 +164,7 @@ func (cmd *Command) parseFlags(args Args) (Args, error) {
 			tracef("processing non bool flag (fName=%[1]q)", flagName)
 			// not a bool flag so need to get the next arg
 			if flagVal == "" {
-				if len(rargs) == 1 {
+				if len(rargs) == 1 || valFromEqual {
 					return &stringSliceArgs{posArgs}, fmt.Errorf("%s%s", argumentNotProvidedErrMsg, firstArg)
 				}
 				flagVal = rargs[1]

command_test.go

@@ -2727,6 +2727,11 @@ func TestFlagAction(t *testing.T) {
 			args: []string{"app", "--f_string="},
 			err:  "flag needs an argument: --f_string=",
 		},
+		{
+			name: "flag_string_error2",
+			args: []string{"app", "--f_string=", "--f_bool"},
+			err:  "flag needs an argument: --f_string=",
+		},
 		{
 			name: "flag_string_slice",
 			args: []string{"app", "--f_string_slice=s1,s2,s3"},