-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perfectionist's Checklist #1612
Comments
@abitrolly I agree with all of these points. In fact these have been raised before see https://github.com/urfave/cli/issues?q=is%3Aopen+is%3Aissue+label%3Aarea%2Fv3 However at this point v2 is in maintenance mode so no new features/functionality. Most if not all of your issues are slated to be fixed in v3. Why v3 you say ? We wanted to take the most requested features and create a new version of the software . As part of this we've rewritten the flag code to use generics so that feature addition is localized and more manageable than it is currently. For example see the recent changes for persistent flags in v3. It required an update to just 4 files vs currently we would have to update almost 15-20 files. So code maintenance is better . That being said are you up for these changes coming to v3? |
I don't understand generics, and I don't know how much time it will be needed for me to get it, but when |
Thanks @abitrolly |
@abitrolly I like the idea of having a single |
@abitrolly I've discussed with @meatballhat offline and we are going to keep the same Name/Aliases structure and not go back to |
@dearchap thanks for taking this in the works. ) |
Here are some things that I found internally unsatisfying in
v2
.help
commandApp.Name
to beAppName
to make it clear it is only used in help formattingfalse
(--help, -h show help (default: false)
)Fix:(issue_1277) Remove default text for version/help flags #1633
sub add [command options] [arguments...]
)sub add [command options] [arguments...]
)Args: false
to stop passing unparsed arguments #1797To be expanded..
Name: "--password"
andName: "-p, --password"
to simplify grep for looking where options are defined-h
take priority over missing required flag on level aboveWhat problem does this solve?
Reaching inner peace.
The text was updated successfully, but these errors were encountered: