Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perfectionist's Checklist #1612

Closed
6 of 8 tasks
abitrolly opened this issue Dec 3, 2022 · 7 comments
Closed
6 of 8 tasks

Perfectionist's Checklist #1612

abitrolly opened this issue Dec 3, 2022 · 7 comments
Labels
area/v3 relates to / is being considered for v3
Milestone

Comments

@abitrolly
Copy link
Contributor

abitrolly commented Dec 3, 2022

Here are some things that I found internally unsatisfying in v2.

To be expanded..

  • Allow Name: "--password" and Name: "-p, --password" to simplify grep for looking where options are defined
  • Make subcommand -h take priority over missing required flag on level above

What problem does this solve?

Reaching inner peace.

@abitrolly abitrolly added area/v2 relates to / is being considered for v2 status/triage maintainers still need to look into this labels Dec 3, 2022
@dearchap
Copy link
Contributor

dearchap commented Dec 3, 2022

@abitrolly I agree with all of these points. In fact these have been raised before see

https://github.com/urfave/cli/issues?q=is%3Aopen+is%3Aissue+label%3Aarea%2Fv3

However at this point v2 is in maintenance mode so no new features/functionality. Most if not all of your issues are slated to be fixed in v3. Why v3 you say ? We wanted to take the most requested features and create a new version of the software . As part of this we've rewritten the flag code to use generics so that feature addition is localized and more manageable than it is currently. For example see the recent changes for persistent flags in v3. It required an update to just 4 files vs currently we would have to update almost 15-20 files. So code maintenance is better . That being said are you up for these changes coming to v3?

@abitrolly
Copy link
Contributor Author

I don't understand generics, and I don't know how much time it will be needed for me to get it, but when v3 is ready to be used, I can easily go through this checklist to see if it works for me.

@abitrolly abitrolly added the area/v3 relates to / is being considered for v3 label Dec 3, 2022
@abitrolly
Copy link
Contributor Author

@dearchap renamed feature request template to point to v3 #1613

@dearchap
Copy link
Contributor

dearchap commented Dec 3, 2022

Thanks @abitrolly

@meatballhat meatballhat removed the area/v2 relates to / is being considered for v2 label Dec 10, 2022
@meatballhat meatballhat added this to the Release 3.x milestone Dec 10, 2022
@meatballhat meatballhat removed the status/triage maintainers still need to look into this label Apr 27, 2024
@dearchap
Copy link
Contributor

@abitrolly I like the idea of having a single Name: "-p, --password" rather than aliases. I think v1 had support for this. @urfave/cli WDYT ?

@dearchap
Copy link
Contributor

dearchap commented Nov 2, 2024

@abitrolly I've discussed with @meatballhat offline and we are going to keep the same Name/Aliases structure and not go back to "-p, --password" style. I think we've covered all the items issues listed in this issue. Closing for now

@dearchap dearchap closed this as completed Nov 2, 2024
@abitrolly
Copy link
Contributor Author

@dearchap thanks for taking this in the works. )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v3 relates to / is being considered for v3
Projects
None yet
Development

No branches or pull requests

3 participants