Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test bash completion for sub-commands of sub-commands #1668

Closed
schollii opened this issue Jan 27, 2023 · 2 comments
Closed

Test bash completion for sub-commands of sub-commands #1668

schollii opened this issue Jan 27, 2023 · 2 comments
Labels
area/v2 relates to / is being considered for v2 kind/bug describes or fixes a bug status/triage maintainers still need to look into this

Comments

@schollii
Copy link

schollii commented Jan 27, 2023 •
edited
Loading

My urfave/cli version is

2.24.1

Checklist

  • [X ] Are you running the latest v2 release? The list of releases is here.
  • [ X] Did you check the manual for your release? The v2 manual is here
  • [ X] Did you perform a search about this problem? Here's the GitHub guide about searching.

Dependency Management

  • My project is using go modules.

Describe the bug

There is no unit test that would have trapped #1617

To reproduce

Check the PR #1618

Observed behavior

None of the test files were modified

Expected behavior

There should be at least one test file that has additional tests to trap the incorrect behavior that was seen in #1617
@schollii schollii added area/v2 relates to / is being considered for v2 kind/bug describes or fixes a bug status/triage maintainers still need to look into this labels Jan 27, 2023
@skelouse skelouse changed the title your bug title goes here Test bash completion for sub-commands of sub-commands Jan 28, 2023
@dearchap
Copy link
Contributor

@schollii would you like to submit a PR for this ?

@schollii
Copy link
Author

I will try to find some time next couple weeks

@dearchap dearchap mentioned this issue Jun 5, 2023
Merged
@dearchap dearchap closed this as completed Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/v2 relates to / is being considered for v2 kind/bug describes or fixes a bug status/triage maintainers still need to look into this
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schollii @dearchap