Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make %+v formatting of ErrorFormatter optional #578

Closed
cyphar opened this issue Dec 24, 2016 · 2 comments
Closed

Make %+v formatting of ErrorFormatter optional #578

cyphar opened this issue Dec 24, 2016 · 2 comments
Labels
kind/bug describes or fixes a bug

Comments

@cyphar
Copy link

cyphar commented Dec 24, 2016

Not all users want, by default, to have their pkg/error errors' stack traces printed. This should be handled by a --debug flag or Debug option in the App, so that you only get a stack trace if the user actually asked for one.

@jszwedko jszwedko added the kind/bug describes or fixes a bug label Dec 29, 2016
@jszwedko
Copy link
Contributor

👍 I can definitely see that argument, apologies for not conceiving of it when reviewing #560.

I'll mark this as a bug.

@coilysiren
Copy link
Member

Given that this is from last year, I think I'm comfortable closing it 🙂 feel free to re-open / open a new issue / comment in support if there's still interest here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug describes or fixes a bug
Projects
None yet
Development

No branches or pull requests

3 participants