No Error and exist code when using pkg/errors standard package

[ehernandez-xk]

Hi All,

Here is the snippet to reproduce the error

package main

import (
	"errors"

	"github.com/urfave/cli"
)

var testCMD = cli.Command{
	Name: "test",
	Action: func(c *cli.Context) error {
		return errors.New("Error detected")
	},
}

Command line: (The error is not printed)

$ myApp test
$ echo $?
0

This issue was added in 9e5b048 commit
and mentioned in #496 PR

By the way, Thanks for this awesome package.

[ehernandez-xk]

I have noticed that only the errors of type ExitCoder interface are managed and the errors from the standard library are ignored

For example:

  return cli.NewExitError("Error message", 1)

  err := errors.New("errors")
  return cli.NewMultiError(err)

I think the standard errors should be used as well

[wenchma]

I encountered this issue in mac system, but it is OK in linux system.

[jszwedko]

Hi @ehernandez-xk,

Apologies for the delay. #496 added functionality which was later deemed to be backwards incompatible and less flexible for users of the library, backed out in #595. Presently, if you want to have the application exit automatically, you should use cli.NewExitError as you note.

The error is bubbled up so you can still exit at the top-level if desired with something like:

package main                         

import (                             
        "errors"                     
        "fmt"                        
        "os"                         

        "github.com/urfave/cli"      
)                                    

var testCMD = cli.Command{           
        Name: "test",                
        Action: func(c *cli.Context) error {                               
                return errors.New("Error detected")                        
        },                           
}                                    

func main() {                        
        app := cli.NewApp()          

        app.Commands = []cli.Command{testCMD}                              

        err := app.Run(os.Args)      
        if err != nil {              
                fmt.Println(err)     
                os.Exit(1)           
        }                            
} 

app.RunAndExitOnError is provided as a convenience wrapper to automatically do this.

Let me know if this helps!

[ehernandez-xk]

Thank you @jszwedko