Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to release to gopkg.in #962

Closed
coilysiren opened this issue Nov 29, 2019 · 3 comments
Closed

Figure out how to release to gopkg.in #962

coilysiren opened this issue Nov 29, 2019 · 3 comments
Labels
kind/maintenance about releasing / CI / Github / other kind of "meta" project maintenance work

Comments

@coilysiren
Copy link
Member

this is related to #923

@coilysiren coilysiren added the kind/maintenance about releasing / CI / Github / other kind of "meta" project maintenance work label Nov 29, 2019
@asahasrabuddhe
Copy link
Member

I think we do not need to do anything special to release to gopkg.in. Taking a look at this page. There are two URL patterns supported:

gopkg.in/pkg.v3      → github.com/go-pkg/pkg (branch/tag v3, v3.N, or v3.N.M)
gopkg.in/user/pkg.v3 → github.com/user/pkg   (branch/tag v3, v3.N, or v3.N.M)

This is something we already follow this. Therefore, the following should work out well:

gopkg.in/urfave/cli.v1 -> v1 branch or v1.x.x release tags
gopkg.in/urfave/cli.v2 -> v2 branch or v2.x.x release tags

This would work very well for those not using Go Modules. I have also managed to reproduced this :

Screenshot 2019-12-01 at 12 33 54 PM
Code Setup

Screenshot 2019-12-01 at 12 34 05 PM
Output for v1

Screenshot 2019-12-01 at 12 34 44 PM
Output for v2

@asahasrabuddhe
Copy link
Member

I had disabled Go Modules for above project and instead used the project folder as the GOPATH

@coilysiren
Copy link
Member Author

Got it, so it sounds like people who want to download the package from gopkg.in are currently 100% capable of doing so 👍 So I'll close this ♻️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/maintenance about releasing / CI / Github / other kind of "meta" project maintenance work
Projects
None yet
Development

No branches or pull requests

2 participants