Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assess impact of bpo-22708 in our library and test suite. #2750

Open
jalopezsilva opened this issue Oct 11, 2022 · 3 comments
Open

Assess impact of bpo-22708 in our library and test suite. #2750

jalopezsilva opened this issue Oct 11, 2022 · 3 comments
Assignees

Comments

@jalopezsilva
Copy link
Contributor

jalopezsilva commented Oct 11, 2022

See python/cpython#8305 for context.

The HTTP CONNECT message will be upgraded to HTTP/1.1 from HTTP/1.0. I expect a small set of changes in the library itself.

@jalopezsilva jalopezsilva self-assigned this Oct 11, 2022
@graingert
Copy link
Contributor

This got merged 2 weeks ago

@pquentin
Copy link
Member

pquentin commented Apr 18, 2023

Yes, but it barely missed 3.12.0 alpha7 that we're using now through GitHub Actions. The commit will be in 3.12.0 beta1 next month, at which point we will start seeing failures.

It would be nice to fix them before that, of course. But it would require someone to compile Python 3.12 and run our test suite first.

@graingert
Copy link
Contributor

I backported the def _tunnel(self): method from 3.12 and ran the tests on 3.11 and everything passed still, so I don't think any changes are needed from urllib3 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants