Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry exchange always uses random delay #2614

Closed
3 tasks done
BerkliumBirb opened this issue Aug 16, 2022 · 0 comments · Fixed by #2615
Closed
3 tasks done

Retry exchange always uses random delay #2614

BerkliumBirb opened this issue Aug 16, 2022 · 0 comments · Fixed by #2615

Comments

@BerkliumBirb
Copy link

Describe the bug

If you pass randomDelay: false option to retryExchange it'll still use random delay. That's because <anything> || true will always result in true.

https://github.com/FormidableLabs/urql/blob/ce004409bca2944bbab2acdf297227a4a1a5613c/exchanges/retry/src/retryExchange.ts#L47

Reproduction

not needed

Urql version

@urql/exchange-retry v0.3.3

Validations

  • I can confirm that this is a bug report, and not a feature request, RFC, question, or discussion, for which GitHub Discussions should be used
  • Read the docs.
  • Follow our Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(retry): make randomDelay work urql-graphql/urql
1 participant
@BerkliumBirb