Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mjs changes broke builds using create-react-app #640

Closed
zenios opened this issue Mar 18, 2020 · 2 comments · Fixed by #642 or #646
Closed

mjs changes broke builds using create-react-app #640

zenios opened this issue Mar 18, 2020 · 2 comments · Fixed by #642 or #646

Comments

@zenios
Copy link

zenios commented Mar 18, 2020

After upgading to the latest urql + graphcache i get the following errors

./node_modules/@urql/exchange-graphcache/dist/urql-exchange-graphcache.esm.mjs
Can't import the named export 'buffer' from non EcmaScript module (only default export is available)
@kitten
Copy link
Member

kitten commented Mar 18, 2020

Well, this is great. We almost have a fix ready, but we didn't expect to have to work around this Webpack quirk 😅

This was referenced Mar 18, 2020
Closed
Merged
@kitten kitten mentioned this issue Mar 19, 2020
Merged
@kitten
Copy link
Member

kitten commented Mar 19, 2020

Okay, urql@1.9.4 and next-urql@0.3.6 have been fixed up to account for react having no ESM bundle. The fixes for #636 have created a ripple effect of us trying to utilise .mjs and package.json:exports correctly and consistently and on the way we also ran into a Webpack issue. Sorry about that! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zenios @kitten