RFC: urql-storage-capacitor

[productdevbook]

https://github.com/productdevbookcom/urql-storage-capacitor

We published the library. I sent a pr here but it was not accepted. That's why I published it on our side.

But we have a deficiency on the gear side, I don't know how to solve the test errors there. I'm currently using the capacitor on the plug-in side and it works great.

Can you help me with the fix on the test side?

Also, can we add this library to your documentation?

Thank you.
Mehmet

[kitten]

Converted to a discussion, since this isn't an RFC.

Basically, on the Vitest side, it just looks like it's giving you the instructions you need. You need to define mocks that vaguely resemble the exports of the packages you're trying to mock. However, your mocks don't seem right, so this is more appropriate:

vi.mock('@capacitor/network', () => ({
  Network: {
    async getStatus() {
      return {
        connected: true,
        connectionType: 'unknown',
      }
    },
    addListener(_eventName: 'networkStatusChange', _callback: () => void) {
      return {
        remove: () => Promise.resolve(),
      }
    },
  } as import('@capacitor/network').NetworkPlugin,
}))

vi.mock('@capacitor/preferences', () => ({
  Preferences: {
    async configure(_opts: any) {
      /* noop */
    },
    async set(_opts: any) {
      /* noop */
    },
    async get(_opts: any) {
      return { value: '' }
    },
    async keys() {
      return { keys: [] }
    },
    async remove(_opts: any) {
      /* noop */
    },
    async clear() {
      /* noop */
    },
    async migrate() {
      return {
        migrated: [],
        existing: [],
      }
    },
    async removeOld() {
      /* noop */
    },
  } as import('@capacitor/preferences').PreferencesPlugin,
}))

Now, these don't have to be complete and I can see that you're mocking what you need (correctly, it seems) on a per-test basis, but you do have to make sure that you at least get the shape somewhat right in case you're writing a new test that doesn't mock these imports yet.

[productdevbook]

Thank you fixed.

only problem onOnline tested. https://github.com/productdevbookcom/urql-storage-capacitor/blob/17696ddc4e6e3756928e24b0aa9d67dbbc39459c/test/makeAsyncStorage.test.ts#L379-L430

I couldn't figure out how to proceed here.