Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do about ... in npn_GET()? #46

Open
Aariq opened this issue Nov 20, 2024 · 2 comments
Open

What to do about ... in npn_GET()? #46

Aariq opened this issue Nov 20, 2024 · 2 comments
Labels

Comments

@Aariq
Copy link
Collaborator

Aariq commented Nov 20, 2024

Many of the functions have a ... argument that gets passed to httr::modify_url() (via npn_GET() and httr::GET()). Possible named arguments include:

  • scheme = NULL
  • hostname = NULL
  • port = NULL
  • path = NULL
  • query = NULL
  • params = NULL
  • fragment = NULL
  • username = NULL
  • password = NULL

There isn't an equivalent to this in httr2 since things like query and path are set with different functions. Are there any common use cases for ... in rnpn code currently? If not, it may make most sense just to deprecate this functionality.

@Aariq
Copy link
Collaborator Author

Aariq commented Nov 20, 2024

Currently ... absorb misspelled arguments without any error. Gor example,npn_species_state(state = "AZ", kigndm = "Plantae") returns results for both animals and plants and doesn't error because kigndm gets absorbed by ....

@Aariq
Copy link
Collaborator Author

Aariq commented Nov 26, 2024

Maybe pass to query in case there are other query arguments in the API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant